refactor(instr-undici): avoid use of deprecated APIs for diagnostic channels #2457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2457 +/- ##
==========================================
+ Coverage 90.97% 97.07% +6.09%
==========================================
Files 146 8 -138
Lines 7492 410 -7082
Branches 1502 67 -1435
==========================================
- Hits 6816 398 -6418
+ Misses 676 12 -664 |
david-luna
changed the title
trentm
reviewed
Oct 3, 2024
|
@trentm thanks for the review. I've applied your suggestions myself so it's only necessary your approval (not sure of the approve settings in this repo) |
trentm
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
undiciinstrumentation is used deprecated APIs to subscribe to and unsubscribe from diagnostic channels. Eventually these APIs will be removed and the instrumentation won't work with newer versions of Node.js. I've considered to classify it as a fix but the deprecated APIs are still present so I think refactor is better.Short description of the changes
diagnostics_channel.subscribe(name, handler)anddiagnostics_channel.unsubscribe(name, handler)APIs if available and fallback todiagnostics_channel.channel(name)if notNOTE: this PR supersedes #2407